com.unity.cinemachine icon indicating copy to clipboard operation
com.unity.cinemachine copied to clipboard

CMCL-1397: Use TypeCache where appropriate

Open glabute opened this issue 1 year ago • 1 comments

Purpose of this PR

TypeCache is an optimization when iterating type using reflection. Using TypeCache to search for types speeds up domain reload time.

Testing status

  • [ ] Added an automated test
  • [ ] Passed all automated tests
  • [x] Manually tested

glabute avatar Apr 25 '24 13:04 glabute

Codecov Report

Attention: Patch coverage is 22.58065% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 26.95%. Comparing base (ab0f4f1) to head (26f767d).

Files Patch % Lines
...tor/Obsolete/CinemachineVirtualCameraBaseEditor.cs 0.00% 4 Missing :warning:
...machine/Editor/Utility/CmCameraInspectorUtility.cs 0.00% 4 Missing :warning:
...ditor/Editors/CinemachineFreeLookModifierEditor.cs 0.00% 2 Missing :warning:
...ity.cinemachine/Editor/Obsolete/VcamStageEditor.cs 0.00% 2 Missing :warning:
...tor/PropertyDrawers/EmbeddedAssetPropertyDrawer.cs 0.00% 2 Missing :warning:
...r/PropertyDrawers/SplineAutoDollyPropertyDrawer.cs 0.00% 2 Missing :warning:
...tor/Utility/CmPipelineComponentInspectorUtility.cs 0.00% 2 Missing :warning:
...chine/Editor/Utility/EmbeddedAssetEditorUtility.cs 0.00% 2 Missing :warning:
...ity.cinemachine/Editor/Utility/InspectorUtility.cs 0.00% 2 Missing :warning:
...y.cinemachine/Tests/Editor/UpgradeCm2ToCm3Tests.cs 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
- Coverage   27.03%   26.95%   -0.08%     
==========================================
  Files         248      248              
  Lines       27870    27826      -44     
==========================================
- Hits         7535     7501      -34     
+ Misses      20335    20325      -10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 25 '24 13:04 codecov-commenter