UnityRenderStreaming icon indicating copy to clipboard operation
UnityRenderStreaming copied to clipboard

[REQUEST]: Make functions in WebsocketSignaling protected

Open Alwyn-RM opened this issue 1 year ago • 3 comments

Is your feature request related to a problem?

We need to do some additional parsing of the received messages and be able to send out messages over the data channel. We're using a custom WebSocketSignaling class but it would be cleaner to be able to extend the existing one and get access (or override) some of the methods.

Describe the solution you'd like

Make methods in WebSocketSignaling private and preferably virtual

Describe alternatives you've considered

Copying all code from the base class into a new class but that creates issues if base code is updated.

Additional context

No response

Alwyn-RM avatar Aug 25 '23 11:08 Alwyn-RM

@Alwyn-RM OK, I will think about your request. What kind of extension do you add for WebSocketSignaling?

karasusan avatar Aug 29 '23 03:08 karasusan

memo: URS-629

karasusan avatar Aug 29 '23 03:08 karasusan

Mainly because we need to send some additional messages to the node process. That is currently a private function (WSSend). So opening that up by making it public would also work.

Alwyn-RM avatar Aug 29 '23 08:08 Alwyn-RM