UnityRenderStreaming icon indicating copy to clipboard operation
UnityRenderStreaming copied to clipboard

[REQUEST]: Add option to disable URPInitialSetupPostProcessor and/or HDRPInitialSetupPostProcessor

Open timmeh4242 opened this issue 3 years ago • 3 comments

Today I was needing to test some features that were unrelated to Render Streaming that required flipping back to the Built-in pipeline. The project severely stalled when entering playmode, and materials rendered in the built-in scene as pink -> something was auto-magically flipping an SRP back on. This was confusing and then frustrating to find that it existed in a package I do not control.

A feature like this to me feels like it should NEVER modify a project setting. My preference would be for it to be removed, with perhaps a warning in the project settings panel when Render Streaming is installed but no active SRP set.

A sufficient alternative I think would be a warning when entering play mode (with the option to dismiss and not be warned again).

At the moment the only solution appears to be removing the package entirely or embedding it and commenting out the offending bits of code. Open to other options, though it's not clear to me that it's imperative this happen at all.

timmeh4242 avatar Aug 23 '22 00:08 timmeh4242

@tbriley You are saying that this code has issues, right? https://github.com/Unity-Technologies/UnityRenderStreaming/blob/98f6c22fdc7060ecf526c69bd9494a7c0566c496/com.unity.renderstreaming/Editor/RenderPipeline/URPInitialSetupPostProcessor.cs

This is a first commit that this code is merged. https://github.com/Unity-Technologies/UnityRenderStreaming/pull/207

As you said, it looks this code should be fixed the issue.

karasusan avatar Aug 23 '22 02:08 karasusan

memo: URS-498

kannan-xiao4 avatar Aug 23 '22 02:08 kannan-xiao4

Yes, along with HDRPInitialSetupPostProcessor.cs

Another option that comes to mind: a simple console warning, as this would be in alignment with behaviour we see in other Unity packages when an SRP is required but not set (ie, VFX graph).

Will do a test today to check that nothing seriously blows up when this is removed - cheers!

timmeh4242 avatar Aug 23 '22 13:08 timmeh4242