UnityRenderStreaming icon indicating copy to clipboard operation
UnityRenderStreaming copied to clipboard

[REQUEST]: Remove the dependency on node for the signaling part

Open qleguennec opened this issue 3 years ago • 7 comments

Is your feature request related to a problem?

We need to ship a version of this codebase in an executable. The node dependency increases the build size and complicates the build process.

Describe the solution you'd like

The signaling part of this solution could be done in C# in Unity. No node dependency would be required.

Describe alternatives you've considered

No response

Additional context

No response

qleguennec avatar Aug 21 '22 16:08 qleguennec

@qleguennec You mean that remove the node dependeny from the signaling server?

karasusan avatar Aug 22 '22 01:08 karasusan

@karasusan Yes. Ideally, this would have the effect that we wouldn't need to launch the signaling server prior to using webrtc. The signaling server will be embedded in Unity and would start alongside the rest of the startup scripts.

qleguennec avatar Aug 22 '22 07:08 qleguennec

@qleguennec In other words your idea, Unity runtime should work as a http server for signaling, is it right? This idea is not bad, but I am not sure that how many users hope to realize that. I assume that people who makes web server using nodejs is larger than using .NET.

karasusan avatar Aug 22 '22 10:08 karasusan

@karasusan Just to clarify your opinion, it is based on people that will be able to contribute to the repo? Or on the principle of least astonishment? I'm not sure I understand the base reasoning around your comment.

qleguennec avatar Aug 22 '22 10:08 qleguennec

@qleguennec This is no basis.

I understood your opnition. This is that Unity runtime integrate the signaling server, and reduce the footprint of node server. Surely, it would be valuable as a one option of the signaling implementation.

karasusan avatar Aug 23 '22 03:08 karasusan

@karasusan Okay, I understand.

qleguennec avatar Aug 23 '22 08:08 qleguennec

memo: URS-501

karasusan avatar Aug 30 '22 02:08 karasusan