Unity-Robotics-Hub icon indicating copy to clipboard operation
Unity-Robotics-Hub copied to clipboard

AIRO-1647 Modifying Pick and Place pt. 4 to treat services like services

Open mrpropellers opened this issue 3 years ago • 1 comments

Proposed change(s)

Part 4 of Pick and Place was publishing messages over a service topic using a standard ROS Publisher rather than our API for Services. It also seems to be broken in general due to actions not registering to the message registry. Modified project on both Unity and ROS side to use the Service API for service messages, and added some quality of life updates to the ROS node so starting it without an accompanying Niryo One param server doesn't lock up a user's terminal.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Addresses issue #333 and this forum post.

Types of change(s)

  • [x] Bug fix

Testing and Verification

Ran nodes up to the point where they fail to connect to a Niryo One, which I don't have on hand.

Checklist

  • [x] Ensured this PR is up-to-date with the dev branch
  • [x] Created this PR to target the dev branch
  • [x] Followed the style guidelines as described in the Contribution Guidelines
  • [ ] Added tests that prove my fix is effective or that my feature works
  • [ ] Updated the Changelog and described changes in the Unreleased section
  • [x] Updated the documentation as appropriate

Other comments

mrpropellers avatar Jan 14 '22 23:01 mrpropellers

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

unity-cla-assistant avatar May 21 '23 21:05 unity-cla-assistant