attempt at removing uielements dependency
Description
Please fill this section with a description what the pull request is trying to address and what changes were made.
Testing status & QA
Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
- Complexity:
- Halo Effect:
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
- [ ] Changelog entry added.
- Explains the change in
Changed,Fixed,Addedsections. - For API change contains an example snippet and/or migration example.
- JIRA ticket linked, example (case %<ID>%). If it is a private issue, just add the case ID without a link.
- Jira port for the next release set as "Resolved".
- Explains the change in
- [ ] Tests added/changed, if applicable.
- Functional tests
Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult. - Performance tests.
- Integration tests.
- Functional tests
- [ ] Docs for new/changed API's.
- Xmldoc cross references are set correctly.
- Added explanation how the API works.
- Usage code examples added.
- The manual is updated, if needed.
During merge:
- [ ] Commit message for squash-merge is prefixed with one of the list:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.
After merge:
- [ ] Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.
Codecov Report
Attention: Patch coverage is 9.86547% with 201 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## develop #2243 +/- ##
===========================================
+ Coverage 68.14% 72.14% +3.99%
===========================================
Files 367 550 +183
Lines 53685 98126 +44441
===========================================
+ Hits 36584 70793 +34209
- Misses 17101 27333 +10232
| Flag | Coverage Δ | |
|---|---|---|
| inputsystem_MacOS_6000.3 | 6.43% <12.50%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...sts/InputSystem.Editor/ControlSchemeEditorTests.cs | 100.00% <100.00%> (ø) |
|
| Assets/Tests/InputSystem/CoreTests_Editor.cs | 97.70% <ø> (ø) |
|
| ...stem/Editor/AssetEditor/InputActionAssetManager.cs | 66.39% <ø> (ø) |
|
| ...tem/Editor/AssetEditor/InputActionEditorToolbar.cs | 0.00% <ø> (ø) |
|
| ...stem/Editor/AssetEditor/InputActionEditorWindow.cs | 0.00% <ø> (ø) |
|
| ...em/Editor/AssetEditor/InputActionPropertiesView.cs | 0.00% <ø> (ø) |
|
| ...utsystem/Editor/AssetEditor/InputActionTreeView.cs | 50.20% <100.00%> (ø) |
|
| ...tem/Editor/AssetEditor/InputActionTreeViewItems.cs | 74.91% <ø> (ø) |
|
| ...m/Editor/AssetEditor/InputBindingPropertiesView.cs | 0.00% <ø> (ø) |
|
| ...tem/Editor/AssetEditor/NameAndParameterListView.cs | 0.00% <ø> (ø) |
|
| ... and 93 more |
... and 98 files with indirect coverage changes
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@LeoUnity Please update this branch with latest changes from develop to get critical changes from https://github.com/Unity-Technologies/InputSystem/pull/2260. I do not dare doing it since branch has conflicts I may not understand.