FIX: Update sample materials to be URP/HDRP compatible [TBD]
Description
Switches out sample materials to a shadergraph one that is cross compatible between URP/HDRP. One caveat is that if someone wants to use it with the old built in render pipeline they have to install the shadergraph package. Also, this adds a dependency to our own main project as it is a built in render pipeline project.
Note: Shadergraph version added is the one offered by 22.3 which seems to update just fine across our supported editors
Testing status & QA
Import changed samples locally through the package manager, run every scene in player and play mode in a new URP & HDRP project. (22.3, 6.0 & trunk)
Overall Product Risks
- Complexity: low
- Halo Effect: low to medium
Comments to reviewers
None yet, TBD
Checklist
Before review:
- [ ] Changelog entry added.
- Explains the change in
Changed,Fixed,Addedsections. - For API change contains an example snippet and/or migration example.
- JIRA ticket linked, example (case %<ID>%). If it is a private issue, just add the case ID without a link.
- Jira port for the next release set as "Resolved".
- Explains the change in
- [ ] Tests added/changed, if applicable.
- Functional tests
Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult. - Performance tests.
- Integration tests.
- Functional tests
- [ ] Docs for new/changed API's.
- Xmldoc cross references are set correctly.
- Added explanation how the API works.
- Usage code examples added.
- The manual is updated, if needed.
During merge:
- [ ] Commit message for squash-merge is prefixed with one of the list:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.
After merge:
- [ ] Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.
Codecov Report
Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| Assets/Samples/RebindingUI/Game/Player.cs | 0.00% | 5 Missing :warning: |
@@ Coverage Diff @@
## develop #2223 +/- ##
===========================================
+ Coverage 68.14% 76.70% +8.55%
===========================================
Files 367 465 +98
Lines 53685 87920 +34235
===========================================
+ Hits 36584 67436 +30852
- Misses 17101 20484 +3383
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| Assets/Samples/RebindingUI/Game/Player.cs | 0.00% <0.00%> (ø) |
... and 98 files with indirect coverage changes
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Getting shader errors on build on 6.3 at the moment
Might be that this is still in flight but would recommend updating CHANGELOG to reflect these changes.
@Pauliusd01 Please update this PR with latest develop to get critical CI fix from https://github.com/Unity-Technologies/InputSystem/pull/2260. I do not dare doing it for you since the branch has conflicts I may not understand.