InputSystem icon indicating copy to clipboard operation
InputSystem copied to clipboard

CHANGE: added more information in the dialog to restart the editor.

Open smnwttbr opened this issue 10 months ago • 5 comments

Description

When the editor is restarted, pending import operations and windows are closed. The dialog has added information to inform the user of this. ISXB-608

Changes made

Modified dialog text.

image

Checklist

Before review:

  • [x] Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • [ ] Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • [ ] Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • [ ] Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

smnwttbr avatar Apr 24 '24 03:04 smnwttbr

CLA assistant check
All committers have signed the CLA.

unity-cla-assistant avatar Apr 24 '24 03:04 unity-cla-assistant

In addition the PR is in draft status, you should convert it into a regular PR if there are no further changes planned on it. We typically use drafts only to get some feedback when work is pending / not finished.

ekcoh avatar Apr 24 '24 06:04 ekcoh

I also see you need to sign the license/CLA for CI to pass on this one. This is a one time thing you need to do to contribute to the repo.

ekcoh avatar Apr 24 '24 06:04 ekcoh

Hi, two things:

  1. I assume we've exhausted all other options that don't require this workaround, such as whether it's possible to delay showing this dialog until all importing is complete?
  2. Doesn't restarting the editor automatically continue the import for anything that's not yet imported? When we say the user has to start (or restart) the import process after the editor restarts, where exactly is this button to do this?

duckets avatar Apr 30 '24 13:04 duckets

I'm reluctant to approve this because although technically it explains to the user what to do, even with the improved text, I still think it's a bad user experience and, it's something that first-time Unity users have a high chance of encountering when importing their first demo project or starting their own first project using asset store assets. Therefore it has the potential to be one of the very first things any user experiences when starting their first project in the editor, which I think should be given significantly elevated priority as a user experience.

If it's at all possible, I think it needs looking at more closely and maybe going back to engineers for a solution that doesn't interrupt the package dependency import process.

duckets avatar Jun 13 '24 09:06 duckets