InputSystem icon indicating copy to clipboard operation
InputSystem copied to clipboard

ISXB-358 wildcards not working

Open ritamerkl opened this issue 1 year ago • 1 comments

Description

Fixes the wildcard not working bug

Changes made

Changed: BindingMasks get compared to Bindings with another method (StringMatches) Fixed: Wildcards working now Added: tests for wildcards

cases checked:

  • sign at the beginning
  • sign at the end

Notes

Please write down any additional notes, remove the section if not applicable.

Checklist

Before review:

  • [x] Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • [x] Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • [x] Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • [x] Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

ritamerkl avatar Mar 29 '23 10:03 ritamerkl

There are several test failures which seems to highlight problems with this change.

lyndon-unity avatar Mar 31 '23 13:03 lyndon-unity