InputSystem icon indicating copy to clipboard operation
InputSystem copied to clipboard

Fix XR Tests for 2019.3

Open StayTalm opened this issue 4 years ago • 4 comments

In 2019.3 Device Role got replaced with InputDeviceCharacteristics. Updated XRTests to use Characteristics when working in 2019.3 or greater.

StayTalm avatar Jun 02 '20 23:06 StayTalm

@karljj1 landed a change related to this as part of getting CI back to green. @StayTalm could you merge latest develop and update the PR? Or is it obsoleted by Karl's change?

Rene-Damm avatar Jun 05 '20 11:06 Rene-Damm

I'll do a merge, I would like to move away from using Role since it's being deprecated, so I'm trying to set Characteristics directly instead of converting from role to characteristics.

StayTalm avatar Jun 05 '20 17:06 StayTalm

I'll do a merge, I would like to move away from using Role since it's being deprecated, so I'm trying to set Characteristics directly instead of converting from role to characteristics.

Feel free to redo/change the existing fix.

Rene-Damm avatar Jun 05 '20 17:06 Rene-Damm

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

unity-cla-assistant avatar Oct 20 '21 15:10 unity-cla-assistant

To be merged in #1655.

jfreire-unity avatar Mar 07 '23 13:03 jfreire-unity