InputSystem
InputSystem copied to clipboard
FIX: Allow overriding composite binding parameters
Currently, the InputBindingResolver
uses the binding's path to instantiate a composite binding.
Any parameters are stored in the path as well.
For example, "MyCustomComposite(someParameter=true)"
If any overrides to the path were made at runtime (e.g. to change the parameter to false) they are ignored when the binding is resolved.
This PR changes the InputBindingResolver
to use effectivePath
instead of path
so that parameters of the composite can be changed at runtime.
PSA: We're super slow ATM in getting external PRs in. Reason is we have no good process in place yet and we're figuring out some way to handle external PRs in a reasonable fashion. One problem, for example, is that we can't run our CI directly on these PRs so we have to manually pull in and run the changes. Please stay tuned. The PRs are definitely appreciated.
Thanks for your contribution @jamre. Following-up on this PR we have noticed that nowadays effectivePath
is used, hence this PR can be closed since what you wanted to achieve can now be done.