InputSystem icon indicating copy to clipboard operation
InputSystem copied to clipboard

FIX: Allow overriding composite binding parameters

Open jamre opened this issue 5 years ago • 2 comments

Currently, the InputBindingResolver uses the binding's path to instantiate a composite binding. Any parameters are stored in the path as well. For example, "MyCustomComposite(someParameter=true)"

If any overrides to the path were made at runtime (e.g. to change the parameter to false) they are ignored when the binding is resolved.

This PR changes the InputBindingResolver to use effectivePath instead of path so that parameters of the composite can be changed at runtime.

jamre avatar Jan 23 '20 21:01 jamre

PSA: We're super slow ATM in getting external PRs in. Reason is we have no good process in place yet and we're figuring out some way to handle external PRs in a reasonable fashion. One problem, for example, is that we can't run our CI directly on these PRs so we have to manually pull in and run the changes. Please stay tuned. The PRs are definitely appreciated.

Rene-Damm avatar Feb 03 '20 16:02 Rene-Damm

CLA assistant check
All committers have signed the CLA.

unity-cla-assistant avatar Jun 03 '21 08:06 unity-cla-assistant

Thanks for your contribution @jamre. Following-up on this PR we have noticed that nowadays effectivePath is used, hence this PR can be closed since what you wanted to achieve can now be done.

ekcoh avatar Aug 16 '22 08:08 ekcoh