pm2 icon indicating copy to clipboard operation
pm2 copied to clipboard

feat: stop-exit-codes

Open Lazyuki opened this issue 2 years ago • 4 comments

Q A
Bug fix? yes (adding a missing feature mentioned in the docs)
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #5208
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pull/218 (already added)

This feature stop-exit-codes was first introduced by @jack1142 in the PR #5048 along with the documentation change PR https://github.com/pm2-hive/pm2-hive.github.io/pull/218. However for some reason, only the documentation PR was merged without the actual code and now the live documentation website lists a feature that doesn't actually exist. This of course resulted in this issue #5208 being created.

This PR is continued from jack's PR and adds a few tests. Someone else already made an attempt in #5241 but seems like it was closed without any reason.

Lazyuki avatar Mar 18 '22 23:03 Lazyuki

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 18 '22 23:03 CLAassistant

Would love to see this merged please, will help us out a lot 👍

jrtg avatar Apr 19 '22 14:04 jrtg

Yes please. EDIT: I manually changed these files to match the PR, but it still doesn't seem to be working for me. :(

dperolio avatar Apr 30 '22 02:04 dperolio

Can this be merged please ?

internpoon avatar Jun 03 '22 02:06 internpoon

This feature should be merged, could somebody provide feedback so that it can move forward?

negreanucalin avatar Nov 04 '22 09:11 negreanucalin

@Unitech any guidance here?

TotalLag avatar Nov 06 '22 01:11 TotalLag

This is already mentioned in the docs, but the feature itself does not seem to exist yet. I think this should be removed from the docs until this gets merged.

bramvbilsen avatar Dec 04 '22 20:12 bramvbilsen

In docs, passes tests but not merged?

Considering the fast-pace of Node ecosystem in general, I think this project can do with a bias towards shipping and letting the community deal with potential regressions (that too solved with a bias towards shipping).

Please merge this so the featureset is in-line with current documentation, please. It has been 7 months already.

Thanks

smashah avatar Dec 29 '22 16:12 smashah

feature is mentioned in docs since 2021, this pull request / patch / bugfix is nearly a year old...

really like to see this feature (or at least removed from docs...)

I am quite confused about this. considered switchich from supervisor to pm2 but things like leave me wondering how solid this project is

installing the fork this works fine for my usecase for dispatching forked scripts that should not be restarted when run once successful (app booting database migration, initial caching, etc.)

dreadkopp avatar Feb 04 '23 17:02 dreadkopp

@Unitech can we bump this PR and get it merged please?

smashah avatar Feb 18 '23 23:02 smashah

Merge this please

risserlabs-com avatar Apr 07 '23 17:04 risserlabs-com

When is this going to be released?

smashah avatar May 09 '23 10:05 smashah

Please add support for stop-exit-codes option in the pm2 ecosystem file. Currently it only works in the CLI options.

@Unitech Or advise me on how to do it, and I will try to add it to the codebase.

luketych avatar Aug 30 '23 21:08 luketych

this feature is currently in development: to install it just use npm install -g github:Unitech/pm2#development

@smashah

gamersindo1223 avatar Sep 23 '23 09:09 gamersindo1223