web3-react icon indicating copy to clipboard operation
web3-react copied to clipboard

Consider non-MetaMask injected connector support

Open NoahZinsmeister opened this issue 3 years ago • 2 comments

Support for injected connectors other than metamask should be considered (e.g. trust).

This could be accomplished via a new connector which is more generic and handles edge cases/non-standard behavior better, or potentially this logic could be put in the metamask connector itself

NoahZinsmeister avatar Jan 11 '22 17:01 NoahZinsmeister

Trust wallet works fine with the injected connector as far as I can tell. At least until v6.

ross-rosario avatar Jan 11 '22 22:01 ross-rosario

yeah, in that same vein it's possible that the best thing to do here is just officially deprecate non-eip1193-compliant injected connectors

NoahZinsmeister avatar Jan 12 '22 19:01 NoahZinsmeister

Since it's already implemented, I'll close this issue

https://github.com/Uniswap/web3-react/tree/main/packages/eip1193

v1rtl avatar Aug 18 '22 08:08 v1rtl