v4-periphery icon indicating copy to clipboard operation
v4-periphery copied to clipboard

misc: update solc to 0.8.28

Open worm-emoji opened this issue 9 months ago • 2 comments

Description of changes

This pull request updates the version of solc used from 0.8.26 to 0.8.28. This is desired because Solidity 0.8.27 adds a variety of improvements to via IR builds, which v4 requires.

I understand if this won't be merged but figured I would attempt anyway so I don't have to use my fork of this repo :)

worm-emoji avatar Feb 12 '25 16:02 worm-emoji

Yeah sorry this wont be merged! Interested in how much it imprves gas though? Did you run forge test --isolate and push the gas snapshot changes?

hensha256 avatar Feb 12 '25 16:02 hensha256

Just checked in the snapshots.

worm-emoji avatar Feb 12 '25 17:02 worm-emoji