add burn test #197

Open bizzyvinci opened this issue 2 years ago • 1 comments

Related Issue

Which issue does this pull request resolve? #197

Description of changes

Add test to confirm that burn outside of lock would revert. This is because lockedBy.length is 0 and therefore an underflow error in _accountDelta

Secondly what if an unsafe transfer is done

unsafe transfer is impossible cause OZ implementation strictly complies with the ERC1155 spec.

Jun 17 '23 17:06 bizzyvinci

Eth support has been added and ERC1155 balance check has been moved to PoolManager.t.sol Balance check for ETH is different because before and after balance are the same due to msg.value

Jun 29 '23 18:06 bizzyvinci

Closing as burning outside of a lock is no longer an issue/not allowed. If you'd like to contribute a burn test under the new system design with ERC6909s, feel free to re-open and tag me as a reviewer!

Dec 06 '23 20:12 snreynolds