v4-core icon indicating copy to clipboard operation
v4-core copied to clipboard

πŸ’’ Change `LICENSE` to `AGPL-3.0-only`

Open pcaversaccio opened this issue 1 year ago β€’ 41 comments

As Hayden stated yesterday during the Twitter spaces, Uniswap is considered a pivotal piece of infrastructure. One of the key values of Ethereum is the open-source paradigm. Thus, it should be the logical consequence for Uniswap to use a proper open-source license, as introduced in this PR, in particular since you invite others to contribute for free! Otherwise, your open-source claim is just simply a meme. Full stop.

pcaversaccio avatar Jun 16 '23 11:06 pcaversaccio

Fully support this Let’s make Uniswap truly open source lgtm

giaki3003 avatar Jun 16 '23 12:06 giaki3003

LGTM

0xJepsen avatar Jun 16 '23 14:06 0xJepsen

I think this is the most valuable effort that we have seen come out of the PRs. Bravo. Well thought out design with quality testing.

0xcacti avatar Jun 16 '23 15:06 0xcacti

@pcaversaccio can i legally fork your branch? 😍

wei3erHase avatar Jun 16 '23 15:06 wei3erHase

here for the memes

matthewlilley avatar Jun 16 '23 15:06 matthewlilley

Lgtm

alex-damjanovic avatar Jun 16 '23 15:06 alex-damjanovic

no breaking changes, clean changeset, thoroughly tested

lgtm πŸ‘

defijesus avatar Jun 16 '23 15:06 defijesus

based

Jon-Becker avatar Jun 16 '23 16:06 Jon-Becker

Yep as indicated by $OP$ license is definitely not conducive for open source participation , here is the summary of the diff via ChatGPT

tormentr avatar Jun 16 '23 17:06 tormentr

ship it! πŸ›³οΈ

devtooligan avatar Jun 16 '23 17:06 devtooligan

LGTM 🫑

jeffscottward avatar Jun 16 '23 18:06 jeffscottward

spicy

robriks avatar Jun 16 '23 18:06 robriks

@pcaversaccio our industry values immutability and we cannot guarantee that future versions of AGPL will remain based. I would recommend we explicitly lock the proposed changes to AGPL-3.0-only, particularly since the AGPL-3.0 SPDX identifier has been deprecated.

TimTinkers avatar Jun 16 '23 18:06 TimTinkers

Looks good to me. Let's go ahead and get this merged

buildingthebear avatar Jun 16 '23 18:06 buildingthebear

LGTM great work on this βœ…

TheLDB avatar Jun 16 '23 19:06 TheLDB

LGTM

AyiSoli avatar Jun 16 '23 19:06 AyiSoli

LGTM

JSeam2 avatar Jun 16 '23 22:06 JSeam2

LGTM

meekteek avatar Jun 16 '23 22:06 meekteek

Good catch! LGTM

mrtoronto avatar Jun 16 '23 22:06 mrtoronto

as a software consultant i think we should push back and double click on this issue and try not to boil the ocean

hvdson avatar Jun 16 '23 22:06 hvdson

I am in support of making v4 copyleft. But since this moment provides an opportunity for even more interesting reformβ€”I would propose a variation (DAO Source License) that returns a % of commercial use of v4 without needing to ask, delivered onchain to UNI DAO. Funding good open source software hasn't really worked. Scammers ruined ICOs. Grant requests to use code or get public goods funding are insider games. Developers should get paid for doing things, otherwise, well, more and more code will just be unpublished. This is my suggestion, but open to others.

z0r0z avatar Jun 16 '23 23:06 z0r0z

it lgtm!

o-az avatar Jun 16 '23 23:06 o-az

LGTM

PatrickAlphaC avatar Jun 17 '23 04:06 PatrickAlphaC

looks good to me

portdeveloper avatar Jun 17 '23 05:06 portdeveloper

LGTM

atraxsrc avatar Jun 17 '23 05:06 atraxsrc

🍡 LGTM

0xLiquidGlass avatar Jun 17 '23 08:06 0xLiquidGlass

LGTM! πŸ‘

zxstim avatar Jun 17 '23 08:06 zxstim

LGTM! +1

gianalarcon avatar Jun 17 '23 08:06 gianalarcon

LGTM

AlbionaHoti avatar Jun 17 '23 09:06 AlbionaHoti

I officially endorse this statement.

alphak3y avatar Jun 17 '23 12:06 alphak3y