v3-periphery icon indicating copy to clipboard operation
v3-periphery copied to clipboard

🐛 use solidity version range for interfaces and libraries

Open cruzdanilo opened this issue 2 years ago • 3 comments

this allows apps and integrators to use this project as a library, especially CallbackValidation.

cruzdanilo avatar Jul 29 '22 17:07 cruzdanilo

Hi @cruzdanilo! I have allowed this PR to have our workflows run on it so we can look at getting it merged for you. Sadly the workflows have failed - please can you take a look at the failures! Once they pass we can review it for merging.

hensha256 avatar Aug 11 '22 10:08 hensha256

@hensha256 thank you. the error seems to be about a github integration failure. can you please retry/re-run the github action?

Verifying setup for Prettier…
Verified Prettier setup
Will use Prettier to check the files with extensions css,html,js,json,jsx,md,sass,scss,ts,tsx,vue,yaml,yml,sol
Linting and auto-fixing files in /home/runner/work/v3-periphery/v3-periphery with Prettier…
Prettier found no issues (success)
No changes found with Git

SHA of last commit is "3f4f2c08[55](https://github.com/Uniswap/v3-periphery/runs/7785217331?check_suite_focus=true#step:5:56)cd690f68387dd478c31a0a07bade12"
Creating GitHub check with 0 annotations for Prettier…
Error: Received status code 403

cruzdanilo avatar Aug 11 '22 11:08 cruzdanilo

ah its because this is a fork not a branch - let me see if we can give prettier permissions to run on forks

hensha256 avatar Aug 11 '22 13:08 hensha256

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Oct 10 '22 23:10 stale[bot]

this is still relevant.

cruzdanilo avatar Oct 11 '22 00:10 cruzdanilo

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Dec 25 '22 05:12 stale[bot]

this is still relevant.

cruzdanilo avatar Dec 25 '22 16:12 cruzdanilo

@hensha256 did you manage to give permissions to prettier?

Seesaem avatar Jan 10 '23 14:01 Seesaem

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Mar 13 '23 17:03 stale[bot]

this is still relevant.

cruzdanilo avatar Mar 13 '23 20:03 cruzdanilo

we need this to be merged. the pain the current flow is causing is unwarranted

Dayo-Adewuyi avatar May 01 '23 08:05 Dayo-Adewuyi

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jun 30 '23 20:06 stale[bot]

this is still relevant.

cruzdanilo avatar Jul 02 '23 13:07 cruzdanilo

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 03 '23 09:09 stale[bot]

this is still relevant.

cruzdanilo avatar Sep 03 '23 17:09 cruzdanilo

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Nov 09 '23 22:11 stale[bot]

this is still relevant.

cruzdanilo avatar Nov 09 '23 22:11 cruzdanilo

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jan 09 '24 03:01 stale[bot]

this is still relevant.

cruzdanilo avatar Jan 09 '24 14:01 cruzdanilo