fix compilation error with solc > 0.8, fixes #209

[ChrisiPK]

trafficstars

Fixes the compilation error in PoolLibrary with Solidity 0.8. Now, we first cast to uin160 before casting to address.

[willpote]

Thanks for this change, could you move this to a separate branch called '0.8', similar to what we did for v3-core here?

[ChrisiPK]

I will try to update all the contracts to 0.8 and create a second PR for this.

However, I disagree that this change should not be incorporated into the 0.7 version. It doesn't break compatibility with older versions and enables users to include the PoolAddress contract in their 0.8 projects already. The solidity version pragma of this file doesn't exclude compatibility with 0.8 so it should be fixed to work with 0.8.

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[ChrisiPK]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Still relevant IMHO. Would be happy to hear from maintainers what is blocking it from their perspective.

[therealdannzor]

Curious to know too 😄

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[cruzdanilo]

still relevant

[jmfrancolin]

still relevant

[ahbit]

+1

[ethanolle]

+1

[andreujuanc]

Can anyone check if the truncation is done right? and behaves according to < v8?

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[cruzdanilo]

still relevant

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[ChrisiPK]

Still relevant. I would also like to know if there is anything blocking it and if there is something we can do to move it forward.

@andreujuanc How do you suggest to test this?

[andreujuanc]

@ChrisiPK Sadly I don't remember why I was checking this PR :D

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[passabilities]

any updates?

[xklob]

still relevant

[arr00]

This should be merged @hensha256