v3-info icon indicating copy to clipboard operation
v3-info copied to clipboard

Explorer links on any chain other than Mainnet are broken on Pool page

Open 0xTARC opened this issue 1 year ago • 2 comments

Bug Description Explorer links on PoolPage are always linking to etherscan.io, regardless of the chosen chain

broken-explorer-link

Steps to Reproduce

  1. Switch chain to any chain other than mainnet. For example, switch to Optimism
  2. Navigate to any pool (for example, search OP and select the OP/WETH 30bps pool
  3. Click the explorer link
  4. Note you are taken to etherscan.io, not optimistic.etherscan.io

Repro video: https://github.com/Uniswap/v3-info/assets/97852365/e032e098-4c76-450d-9ac5-15f8aeead3bf

Expected Behavior Clicking the explorer link should navigate to the active chain's explorer

Additional Context PR with fix: https://github.com/Uniswap/v3-info/pull/308

0xTARC avatar Jan 15 '24 19:01 0xTARC

Same issue on transaction links

image

robertu7 avatar Feb 22 '24 10:02 robertu7

Both issues fixed with PR #320

Vanilladelphia avatar Mar 20 '24 04:03 Vanilladelphia