v1-contracts icon indicating copy to clipboard operation
v1-contracts copied to clipboard

Published 20 hours ago • verified publisher icon Uniswap

Doesn’t woks with ᴇʀᴄ20 tokens which always returns nothing.

Open ytrezq opened this issue 5 years ago • 1 comments

Not that Vyper uses RETURNDATASIZE, but the used memory location for returning data always contains nothing…

This results in the same as https://medium.com/coinmonks/missing-return-value-bug-at-least-130-tokens-affected-d67bf08521ca

ytrezq avatar Aug 19 '19 21:08 ytrezq

If it returns nothing it is not erc20. ERC20 requires that transferFrom and transfer return bool.

wjmelements avatar Jan 21 '20 23:01 wjmelements