smart-order-router icon indicating copy to clipboard operation
smart-order-router copied to clipboard

fix: add USDC_NATIVE to BASES_TO_CHECK_TRADES_AGAINST in the StaticV3SubgraphProvider

Open iherger opened this issue 1 year ago • 2 comments

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR adds the respective USDC_NATIVE tokens for Arbitrum, Ava, Base, Cell, Optimism and Polygon to the BASES_TO_CHECK_TRADES_AGAINST constant. USDC_NATIVE pools have become a major source of liquidity recently.

Using the StaticV3SubgraphProvider with an extended base token set is important in certain circumstances, e.g. when the respective subgraph has failed (currently the case for e.g. Arbitrum, Optimism, Polygon).

  • What is the current behavior? (You can also link to an open issue here)

Currently, USDC_NATIVE is not used as a BASES_TO_CHECK_TRADES_AGAINST in the StaticV3SubgraphProvider

  • What is the new behavior (if this is a feature change)?

More and better liquidity routes are found on Arbitrum, Avax, Base, Cell, Optimism and Polygon when using the StaticV3SubgraphProvider.

  • Other information:

iherger avatar Feb 20 '24 08:02 iherger

OK to add USDC_NATIVE for v3 static subgraph provider, although v3 subgraph is live in routing-api.

jsy1218 avatar Feb 20 '24 12:02 jsy1218

@jsy1218 thanks. How is routing-api dealing with the failed subgraph on polygon?

iherger avatar Feb 20 '24 13:02 iherger

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar May 17 '24 18:05 stale[bot]