Uniswap
[Bug] Data modification problem - onModification
📱 Interface Affected
Which application are you experiencing issues with?
- [x] Web (app.uniswap.org)
- [ ] Wallet Extension (wallet.uniswap.org)
- [ ] Wallet Mobile App
- [ ] iOS
- [ ] Android
- [ ] Both
🧩 App Version
- Version (if known):
- [x] Production build
- [ ] Development build
💻 System / Environment Info
Please provide details about your environment:
- Browser (name + version): Chrome Version 139.0.7258.157
- OS / Platform (e.g. iOS 17, Windows 11, Android 14): Windows 11
- Device (e.g. iPhone 14 Pro, Pixel 7, MacBook Pro 2023): Asus vivobook
- Wallet used (e.g. Uniswap Wallet, MetaMask, Rainbow): Hinkal Wallet, Avocado Wallet( any smart contract wallet)
- Network (e.g. Ethereum Mainnet, Arbitrum, Base, etc.): Any network.
🔁 Steps to Reproduce
- Start a swap that requires an ERC-20 approval.
- Confirm the approval transaction in the wallet.
- Observe the approval step result and transactions UI/state.
- Proceed to the swap step (optional) and observe that swap tracking works as expected.
✅ Expected Behavior
What should have happened? It should show successful transaction.
❌ Actual Behavior
What actually happened? It showing that transaction was failed.
📸 Screenshots or Screen Recording
Please upload any relevant screenshots or recordings to help us understand the issue better.
🧾 Additional Context
Any extra details? (e.g. logs, error messages, recent updates, beta flags enabled, etc.)
I go in the uniswap code and what I detect is that, since transaction data is changed from smart contract wallet, it runs interfaceUpdateTransactionInfo of slice.ts, but problem is that addTransaction is not called before. This is happening only for approval transaction step.
⚠️ Please redact or avoid sharing sensitive data such as private keys, seed phrases, or personally identifying info.
