interface icon indicating copy to clipboard operation
interface copied to clipboard
verified publisher icon Uniswap

Fix for Uniswap #2648: Sets price in price bar to match the execution price

Open davarg5 opened this issue 2 years ago • 0 comments

This PR makes it so that the price in the price bar matched the execution price, not the price of 1 base, as shown below.

Uniswap exec price issue

Above we see 1 ETH = 20.2571 DAI, which is ~$20.27. Before, the price shown was the price of 1 ETH.

Also, on a side note, I experienced an issue while trying to run this locally. After cloning down the repo and running yarn install and yarn web start at the project's root, I got the below error:

uniswap running issues

I was able to X it out in the browser and continue working, but just a heads up.

davarg5 avatar Jan 12 '24 05:01 davarg5