interface icon indicating copy to clipboard operation
interface copied to clipboard

Add EIP6963 Support

Open trevoraron opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe. I'm building a browser wallet and it does not display well in Uniswap! My wallet supports eip6963 but uniswap doesn't. I could build support for my wallet directly into uniswap frontend, but that feels ugly and a hacky solution

Describe the solution you'd like Uniswap supports EIP6963 (https://eips.ethereum.org/EIPS/eip-6963) and will dynamically render relevant wallets users have installed when 'connect wallet button' is hit based on the eip

Describe alternatives you've considered I can add special cases for my wallet here: https://github.com/Uniswap/interface/blob/876d3a1cc343a2ea822243b2a579f4c185722064/src/connection/utils.ts#L13

and here: https://github.com/Uniswap/interface/blob/876d3a1cc343a2ea822243b2a579f4c185722064/src/react-app-env.d.ts#L21

Additional context none!

trevoraron avatar Nov 09 '23 23:11 trevoraron

Hey @trevoraron! 6963 support is coming soon, you can demo here https://interface-git-eip6963connector-uniswap.vercel.app/swap

cartcrom avatar Nov 09 '23 23:11 cartcrom

@cartcrom ah the site is down. can you link the issue / pr where this is being worked on?

trevoraron avatar Nov 21 '23 17:11 trevoraron