interface icon indicating copy to clipboard operation
interface copied to clipboard
verified publisher icon Uniswap

fix: Make Swap to / from toggle keyboard accessible

Open darkwing opened this issue 2 years ago • 1 comments

Description

At present the down/up-arrow button to switch the "You pay" and "You receive" value is not keyboard accessible. Simply switching to using a button element, with some helpful CSS, makes this element more accessible.

Screen capture

https://github.com/Uniswap/interface/assets/46655/a61871d2-8c48-4cb4-9880-62dcf1e41f9e

QA (ie manual testing)

  1. Open the Swaps page
  2. Tab until you get to the Down/Up toggle
  3. Press enter a bunch
  4. See the values change

Devices

Automated testing

  • [ ] Unit test
  • [ ] Integration/E2E test

darkwing avatar Oct 13 '23 02:10 darkwing

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 2:53am

vercel[bot] avatar Oct 13 '23 02:10 vercel[bot]