interface icon indicating copy to clipboard operation
interface copied to clipboard

fix: Use current network name in Gas Breakdown tooltip

Open darkwing opened this issue 1 year ago β€’ 5 comments

Description

Fixes the GasBreakdownTooltip to use the current network name instead of the hardcoded "Ethereum network" text

Screen capture

Before

SCR-20230910-jjcu

After

SCR-20230910-jgkq

Test plan

Reproducing the error

  1. Switch to any non-EthereumMainnet network
  2. Go to Swaps
  3. Select "to" and "from" tokens
  4. Wait for the the gas estimate icon to display
  5. Hover of the gas estimate icon to see the GasBreakdownTooltip
  6. Ensure that the network name matches the current network

QA (ie manual testing)

  • [ ] N/A

Devices

Automated testing

  • [ ] Unit test
  • [ ] Integration/E2E test

darkwing avatar Sep 10 '23 15:09 darkwing

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
interface βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 12, 2023 1:51am

vercel[bot] avatar Sep 10 '23 15:09 vercel[bot]

Codecov Report

Merging #7292 (75f12b3) into main (5fee3c6) will decrease coverage by 2.43%. The diff coverage is 100.00%.

:exclamation: Current head 75f12b3 differs from pull request most recent head 1bde62e. Consider uploading reports for the commit 1bde62e to get more accurate results

Flag Coverage Ξ”
cloud-tests 87.27% <ΓΈ> (+3.66%) :arrow_up:
unit-tests 40.28% <100.00%> (-2.54%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 29 '23 18:09 codecov[bot]

this is a duplicate of #6979 but we'll probably merge whichever one updates first

just-toby avatar Oct 04 '23 21:10 just-toby

@darkwing can you rebase and fix conflicts?

just-toby avatar Oct 04 '23 21:10 just-toby

Updated as requested!

darkwing avatar Oct 12 '23 01:10 darkwing