interface icon indicating copy to clipboard operation
interface copied to clipboard

It always displays a "swap failed" popup when performing a swap with smart wallet like loopring wallet and ambire wallet.

Open johnloopring opened this issue 1 year ago • 7 comments

Is your feature request related to a problem? Please describe. It always displays a "swap failed" popup when performing a swap with smart wallet like loopring wallet and ambire wallet. paste (5) The reason is that uniswap checks swap data with data fetched from chain by hash. Following is the code check if data are same

if (tx.data !== response.data) {
  sendAnalyticsEvent(SwapEventName.SWAP_MODIFIED_IN_WALLET, {
    txHash: response.hash,
    ...analyticsContext,
  })
  throw new ModifiedSwapError()
}

Describe the solution you'd like Add whitelist for smart wallets.

Describe alternatives you've considered Don't check swap data with data fetched from chain.

Additional context Add any other context or screenshots about the feature request here.

johnloopring avatar Jun 29 '23 10:06 johnloopring

#6860 pr for second solution

johnloopring avatar Jun 29 '23 10:06 johnloopring

Can we have an update for this issue?

And also, we should check if the destination address is a smart contract, if so, ignore the swap data check.

johnnyleejy avatar Jul 25 '23 04:07 johnnyleejy

This is also affecting Sequence wallet too.

attente avatar Aug 02 '23 18:08 attente

This check is also not effective because it happens after the transaction has been confirmed on-chain.

attente avatar Aug 02 '23 18:08 attente

Adding my support for this issue as it's negatively impacting a lot of our users!

gglucass avatar Aug 04 '23 12:08 gglucass

facing this on multiple wallets now - metamask, ledger desktop. any one got any workaround for this?

jaded-dump avatar Aug 04 '23 19:08 jaded-dump

+1 gratuitous "me too" for Chrome v118.0.5993.70 x86_64, Metamask v11.1.2, Ledger Nano X (Hardware v2.0, Firmware v2.2.2, Microcontroller v2.30, Bootloader 1v.16), WebHID, Ledger Ether App v1.10.3, with blind signing enabled. No feedback or explanation.

JonathanWheeler avatar Oct 11 '23 02:10 JonathanWheeler