interface icon indicating copy to clipboard operation
interface copied to clipboard

feat(iframe): iframe ui updates

Open ianlapham opened this issue 3 years ago • 3 comments

  • update for hiding components when app rendered witin iframe
  • example here: https://jsfiddle.net/ianlapham/hme9ucr7/12/

ianlapham avatar Jul 02 '21 02:07 ianlapham

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uniswap/uniswap-interface/rCiwWZvHUfT2GpFyB99icG5Z17Pa
✅ Preview: https://uniswap-interface-git-iframe-updates-uniswap.vercel.app

vercel[bot] avatar Jul 02 '21 02:07 vercel[bot]

note that these two changes (domain detection and iframe detection) will make our integration tests less reliable for catching issues. we should either a) increase the scope of our integration tests to include both app.uniswap.org and localhost:x + iframe/non-iframe, or b) only test one domain and try to make the iframe stuff work responsively for all devices

moodysalem avatar Jul 07 '21 21:07 moodysalem

Yo we have a direct use case for this fix, I was wondering if there is any update on when this could be pushed.

it seems that this could change the game for us! @moodysalem

cashewnutz avatar Aug 06 '21 15:08 cashewnutz