examples icon indicating copy to clipboard operation
examples copied to clipboard

Update examples for new v3-sdk version

Open Florian-S-A-W opened this issue 1 year ago • 8 comments

Update all examples to use the new v3-sdk version published by the Uniswap foundation. Delete multicall example.

Florian-S-A-W avatar Dec 27 '23 16:12 Florian-S-A-W

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None 0 23.3 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 64.6 kB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem, unsafe +20 11.8 MB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem, unsafe +9 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +5 3.25 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem +8 4.61 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, unsafe +26 12.1 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, unsafe +10 11 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 1.89 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 1.89 MB nicolo-ribaudo
npm/@babel/[email protected] environment Transitive: filesystem, unsafe +102 15.3 MB nicolo-ribaudo
npm/@babel/[email protected] environment Transitive: filesystem, unsafe +18 12.6 MB nicolo-ribaudo
npm/@babel/[email protected] None +1 275 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 246 kB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +5 8.69 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +9 5.84 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +2 4.91 MB nicolo-ribaudo
npm/@babel/[email protected] environment 0 2.41 MB nicolo-ribaudo
npm/@babel/[email protected] environment 0 2.41 MB nicolo-ribaudo
npm/@jridgewell/[email protected] None +2 265 kB jridgewell
npm/@types/[email protected] Transitive: environment +2 4.91 MB types
npm/@types/[email protected] None +2 236 kB types
npm/@types/[email protected] None 0 185 kB types
npm/@types/[email protected] None 0 185 kB types
npm/@types/[email protected] None +7 10.6 MB types
npm/@types/[email protected] None 0 3.51 MB types
npm/@types/[email protected] None 0 3.51 MB types
npm/@types/[email protected] None 0 3.51 MB types
npm/@types/[email protected] None +4 1.63 MB types
npm/@types/[email protected] None 0 33.1 kB types
npm/@types/[email protected] None +3 1.59 MB types
npm/@types/[email protected] None 0 365 kB types
npm/@uniswap/[email protected] environment, network Transitive: filesystem, shell +50 24.2 MB jsy1218
npm/@uniswap/[email protected] None +3 6.41 MB emag3m
npm/@uniswapfoundation/[email protected] None 0 83.2 kB koraykoska
npm/@uniswapfoundation/[email protected] None +1 499 kB
npm/[email protected] None 0 531 kB marijn
npm/[email protected] environment, filesystem +5 4.49 MB ai
npm/[email protected] environment, filesystem +4 4.48 MB ai
npm/[email protected] None 0 1.93 MB caniuse-lite
npm/[email protected] None 0 1.94 MB caniuse-lite
npm/[email protected] None 0 1.94 MB caniuse-lite
npm/[email protected] None 0 1.94 MB caniuse-lite
npm/[email protected] Transitive: environment, filesystem +6 5.17 MB zloirock
npm/[email protected] Transitive: environment, filesystem +5 5.17 MB zloirock
npm/[email protected] environment, filesystem Transitive: unsafe +23 7.58 MB eslintbot
npm/[email protected] environment, filesystem +1 3.05 MB eslintbot
npm/[email protected] network 0 28.6 kB rubenverborgh
npm/[email protected] None 0 186 kB evilebottnawi
npm/[email protected] environment, filesystem +1 221 kB ai
npm/[email protected] environment, filesystem 0 197 kB ai
npm/[email protected] Transitive: eval +8 173 kB ljharb
npm/[email protected] environment, eval +6 3.23 MB fabiosantoscode
npm/[email protected] environment, eval 0 2.12 MB fabiosantoscode
npm/[email protected] None 0 73.1 kB ethan_arrowood

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar Dec 27 '23 16:12 socket-security[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@uniswap/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar Jan 25 '24 12:01 socket-security[bot]

@SocketSecurity ignore npm/@uniswap/[email protected]

Florian-S-A-W avatar Jan 25 '24 12:01 Florian-S-A-W

How does this bot not recognize 4.0.0 is newer than 3.3.0

Florian-S-A-W avatar Jan 25 '24 12:01 Florian-S-A-W

@Florian-S-A-W Sorry about this, I'll look into why Socket is not recognizing version 4. Feel free to merge anyway.

mr-uniswap avatar Jan 25 '24 18:01 mr-uniswap

I know this message doesn't make much sense, but the package @uniswap/[email protected] actually has been deprecated by the maintainer with the message "Use >3.3.0". You can see the same information displayed on the official npm package page: https://www.npmjs.com/package/@uniswap/v2-sdk/v/4.0.0

Is it possible to bump the package to @uniswap/[email protected] which is not deprecated?

feross avatar Jan 25 '24 18:01 feross

The latest commit fixes this issue @mr-uniswap @feross SocketSecurity doesn't seem to recognize package aliases - we use @uniswapfoundation/v2-sdk here as the package source for @uniswap/v2-sdk.

Florian-S-A-W avatar Jan 26 '24 19:01 Florian-S-A-W

There are no changes to the lint that fails here.

Florian-S-A-W avatar Apr 18 '24 11:04 Florian-S-A-W