deploy-v3 icon indicating copy to clipboard operation
deploy-v3 copied to clipboard

Feedback: after deploying v3 contracts to OP Sepolia

Open sbvegan opened this issue 2 years ago • 1 comments

Deploy the v3 protocol contracts feedback

Following a long in the readme:

issue with npx command

The following command doesn't work for some reason:

soyboy@soyboys-Air deploy-v3 % npx @uniswap/deploy-v3 --help               
sh: deploy-v3: command not found

building from source

So I built it from source, but I got some issues. I changed my node version to v16 and that worked.

yarn
yarn build

running from source

Note, I think there should be a call out that the private key needs 0x prepended.

yarn start \
-pk <0xprivate-key> \
-j https://sepolia.optimism.io/ \
-w9 0x4200000000000000000000000000000000000006 \
-ncl ETH \
-o 0xA8F66A5DDb07f8dF3A4Ab7B708018d1B12C6e433

Success

state.json

{
  "v3CoreFactoryAddress": "0x8CE191193D15ea94e11d327b4c7ad8bbE520f6aF",
  "multicall2Address": "0x80e4e06841bb76AA9735E0448cB8d003C0EF009a",
  "proxyAdminAddress": "0x3D0bD47e6Bc053aa730c6c28DD89bA9145c86232",
  "tickLensAddress": "0xCb7f54747F58F8944973cea5b8f4ac2209BadDC5",
  "nftDescriptorLibraryAddressV1_3_0": "0x0CeBF58b0B561d6EfE36742e3A25De74E4D83036",
  "nonfungibleTokenPositionDescriptorAddressV1_3_0": "0x41570951276d17FFF1Ebf579F7d28F5ffB7e4480",
  "descriptorProxyAddress": "0x802c58698b21FC9ea7145C88bbB233C9188CdCe2",
  "nonfungibleTokenPositionManagerAddress": "0xdA75cEf1C93078e8b736FCA5D5a30adb97C8957d",
  "v3MigratorAddress": "0xE7EcbAAaA54D007A00dbb6c1d2f150066D69dA07",
  "v3StakerAddress": "0x78eF13931e5625C828ef8Ec455ba7fa09fDa9808",
  "quoterV2Address": "0x0FBEa6cf957d95ee9313490050F6A0DA68039404",
  "swapRouter02": "0x9203F5E91aA591940078916EDF1339D978F34b64"
}

sbvegan avatar Dec 20 '23 23:12 sbvegan

Additionally it would be nice if etherscan contract verification was built in.

sbvegan avatar Dec 20 '23 23:12 sbvegan