nav icon indicating copy to clipboard operation
nav copied to clipboard

Ignore VLANs with non-numerical tags in Juniper NETCONF responses.

Open lunkwill42 opened this issue 2 years ago • 3 comments

PortAdmin only cares about VLANs that can be identified through a proper 12-bit integer tag, so it should be safe to ignore ones that do not conform to the expected response from Juniper switches.

Fixes #2452

lunkwill42 avatar Jul 21 '22 10:07 lunkwill42

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 21 '22 10:07 sonarqubecloud[bot]

Codecov Report

Merging #2453 (b9c769b) into master (26c69f1) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2453      +/-   ##
==========================================
+ Coverage   52.72%   52.76%   +0.03%     
==========================================
  Files         552      552              
  Lines       40186    40186              
==========================================
+ Hits        21190    21204      +14     
+ Misses      18996    18982      -14     
Impacted Files Coverage Δ
python/nav/portadmin/napalm/juniper.py 40.34% <100.00%> (+6.00%) :arrow_up:

codecov[bot] avatar Jul 21 '22 10:07 codecov[bot]

Test results

     12 files       12 suites   13m 59s :stopwatch: 3 089 tests 2 993 :heavy_check_mark:   96 :zzz: 0 :x: 8 742 runs  8 454 :heavy_check_mark: 288 :zzz: 0 :x:

Results for commit b9c769b7.

github-actions[bot] avatar Jul 21 '22 10:07 github-actions[bot]