nav icon indicating copy to clipboard operation
nav copied to clipboard

Published 20 hours ago • verified publisher icon Uninett

Remove needless carbon data chunking from activeipcollector

Open lunkwill42 opened this issue 6 years ago • 1 comments

I'm looking at this code specifically because of its use of xrange(), which won't work under Python 3.

However, I have questions regarding the assumptions made in this comment: https://github.com/UNINETT/nav/blob/6804f2336d9bf261d80767227d57feafe1341b2f/python/nav/activeipcollector/manager.py#L44-L50

The carbon-dispatching code already chunks data, so I'm not sure I support this conclusion. Opening an issue to have a discussion about it.

lunkwill42 avatar Apr 13 '18 07:04 lunkwill42

This is still a valid proposition. Carbon data is always chunked into packets based (more-or-less) on MTU by this function: https://github.com/Uninett/nav/blob/e6634e512c8ecf283c85a701366620e724806ab7/python/nav/metrics/carbon.py#L135-L159

I.e. activeipcollector's added chunking hasn't mattered since the RRDtool days.

lunkwill42 avatar Jul 25 '22 11:07 lunkwill42