Argus icon indicating copy to clipboard operation
Argus copied to clipboard

Move notificationprofile.Filter stuff to own place

Open hmpf opened this issue 1 year ago • 3 comments

Grep for "XXX" for hardcoded methods that need to move.

hmpf avatar May 13 '24 12:05 hmpf

Test results

       7 files     553 suites   21m 42s :stopwatch:    449 tests    448 :heavy_check_mark: 1 :zzz: 0 :x: 3 143 runs  3 136 :heavy_check_mark: 7 :zzz: 0 :x:

Results for commit 440ebf22.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 13 '24 12:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 92.99191% with 26 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (cdc23e5) to head (93dbbf8).

Files Patch % Lines
src/argus/compat.py 64.00% 9 Missing :warning:
src/argus/filter/filterwrapper.py 93.51% 7 Missing :warning:
src/argus/filter/validators.py 54.54% 5 Missing :warning:
src/argus/filter/filters.py 97.89% 2 Missing :warning:
src/argus/filter/V1/serializers.py 98.07% 1 Missing :warning:
src/argus/filter/checks.py 90.00% 1 Missing :warning:
src/argus/notificationprofile/checks.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
- Coverage   84.81%   84.36%   -0.46%     
==========================================
  Files          76       83       +7     
  Lines        3846     3926      +80     
==========================================
+ Hits         3262     3312      +50     
- Misses        584      614      +30     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 22 '24 11:05 codecov-commenter