Argus icon indicating copy to clipboard operation
Argus copied to clipboard

Make it possible to plug in context processors included with apps

Open hmpf opened this issue 1 year ago • 3 comments

Bonus: halt setup with a traceback if the JSON in EXTRA_APPS/OVERRIDING_APPS is buggy!

hmpf avatar May 08 '24 11:05 hmpf

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.81%. Comparing base (05d26f0) to head (9187b71). Report is 10 commits behind head on master.

Files Patch % Lines
src/argus/site/utils.py 94.11% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   84.50%   84.81%   +0.30%     
==========================================
  Files          76       76              
  Lines        3808     3832      +24     
==========================================
+ Hits         3218     3250      +32     
+ Misses        590      582       -8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 08 '24 11:05 codecov-commenter

Test results

       7 files     616 suites   22m 55s :stopwatch:    488 tests    487 :heavy_check_mark: 1 :zzz: 0 :x: 3 416 runs  3 409 :heavy_check_mark: 7 :zzz: 0 :x:

Results for commit 9187b715.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 08 '24 11:05 github-actions[bot]

Can't see anything wrong with the added functionality itself (except it seems to me that GNOC will still bypass all these hook-ins by writing their own settings file by hand?)

I've grown fond of it myself, much quicker adjusting settings by changing a json file that I cat(1) into the environment variable than adjusting the settings file and urls.py when flipping between branches with different needs. Pretty good dev UX!

hmpf avatar May 14 '24 13:05 hmpf