Argus icon indicating copy to clipboard operation
Argus copied to clipboard

Add flag to `toggle_profile_activation` command to turn all off

Open johannaengland opened this issue 10 months ago • 4 comments

Originally posted by @hmpf in https://github.com/Uninett/Argus/pull/749#pullrequestreview-2000621163

johannaengland avatar Apr 15 '24 10:04 johannaengland

I think you can combine this one and #757 and toggle_notification_profiles into a single command.

"list" is incompatible with the others, it might even be the fallback if there are no flags.

hmpf avatar Apr 16 '24 11:04 hmpf

I have trouble picturing how that would look like? Would list be a flag that if used like this toggle_profile_activation --list just list all notification profiles?

That seems un-intuitive for me, because what if we want to later add another management command that does something else with notification profiles and there it might also be useful to know all profiles, then we would have to double the code or call this command before even though we don't want to do anything with the activation.

I would prefer to have these separate and then we can mention the management command in the helptext for toggle_profile_activation.

johannaengland avatar Apr 16 '24 11:04 johannaengland

Add flag where? To what? What are we talking about here?

lunkwill42 avatar Apr 17 '24 06:04 lunkwill42

This can then also be added to the documentation introduced in #765

johannaengland avatar Apr 18 '24 12:04 johannaengland