Argus icon indicating copy to clipboard operation
Argus copied to clipboard

Add "fake" ticket page that DummyPlugin links to when autocreating tickets

Open stveit opened this issue 9 months ago • 4 comments

Scope and purpose

Fixes #1194.

Adds a page with information from an incident that kinda simulates what a real ticket could look like on a ticket site (very basic page). DummyPlugin will return a URL to this page when you use the "Create ticket" function.

Example of the basic page (uses a ticket html file that already existed): image

The url has the format /incidents/fake_ticket/<pk>/. I'll happily take suggestions for URL names and such, or potentially other ways to generate a page like this. I kinda just went with the "fake" naming scheme, but maybe it should be called something else. Maybe /incidents/dummy_ticket/<pk>/ instead?

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is. More information about contributing to Argus can be found in the Development docs.

  • [x] Added a changelog fragment for towncrier
  • [x] Added/amended tests for new/changed code
  • [ ] Added/changed documentation
  • [x] Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • [x] The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • [ ] If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • [x] If this results in changes in the UI: Added screenshots of the before and after
  • [ ] If this results in changes to the database model: Updated the ER diagram

stveit avatar May 26 '25 13:05 stveit

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (4fc7811) to head (c83949f).

Files with missing lines Patch % Lines
src/argus/htmx/incident/views.py 54.54% 5 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
- Coverage   78.97%   78.93%   -0.04%     
==========================================
  Files         120      120              
  Lines        5294     5308      +14     
==========================================
+ Hits         4181     4190       +9     
- Misses       1113     1118       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar May 28 '25 07:05 codecov-commenter

"Demo ticket" might be another option for showing that it is not a real ticket

johannaengland avatar May 30 '25 07:05 johannaengland

I will hand-check this when I can, no merging or approves before that.

hmpf avatar Jun 13 '25 08:06 hmpf