netcdf-cxx4 icon indicating copy to clipboard operation
netcdf-cxx4 copied to clipboard

Published 20 hours ago • verified publisher icon Unidata

Refactor classes for atomic types

Open ZedThree opened this issue 1 year ago • 2 comments

  • make ctors all inline
  • use intermediate class NcAtomic to reduce duplication of equality operator
  • now classes are only a few lines each, move them all into ncType.h header

Includes #144. In total this removes ~1k lines

ZedThree avatar Jan 04 '24 16:01 ZedThree

Reviewing the CXX PR's, I have some work to do with the cxx4 CI, e.g. 'add some'. Once I have that in place I will be able to go through and merge the PR's you've submitted. Thanks!

WardF avatar Jan 23 '24 19:01 WardF

Did you see #139? It adds some basic CI

On Tue, 23 Jan 2024, 19:36 Ward Fisher, @.***> wrote:

Reviewing the CXX PR's, I have some work to do with the cxx4 CI, e.g. 'add some'. Once I have that in place I will be able to go through and merge the PR's you've submitted. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/Unidata/netcdf-cxx4/pull/146#issuecomment-1906794781, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALLAXW3ZH3SAYEC233INYDYQAGKVAVCNFSM6AAAAABBNFNX6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWG44TINZYGE . You are receiving this because you authored the thread.Message ID: @.***>

ZedThree avatar Jan 23 '24 21:01 ZedThree