netcdf-c icon indicating copy to clipboard operation
netcdf-c copied to clipboard

Support scalars in Zarr

Open mannreis opened this issue 9 months ago • 5 comments

Quick patch for https://github.com/Unidata/netcdf-c/issues/3108.

This PR relies on .zarray having chunk and shape keys that are empty arrays, also checking if .zattrs contains an empty array for _ARRAY_DIMENSIONS. Under this assumptions we can treat the variable as a scalar instead of ignoring as it is being done.

mannreis avatar Mar 11 '25 16:03 mannreis

Could you indent the contents of the new conditional, and un-dedent the else line and closing curly brace? The current indentation makes parsing the meaning more involved.

DWesl avatar Mar 11 '25 22:03 DWesl

Looks great! I am getting https://github.com/Unidata/netcdf-c/pull/3086/ merged in now that I've figured out the Fortran issue, and after I pull that in I will get this.

WardF avatar Mar 19 '25 16:03 WardF

Thanks for your patience; now that netCDF-Fortran v4.6.2 is out, and the docker work for regression testing has been integrated, I'm happy to say we're starting to get the backlog cleared!

WardF avatar Apr 02 '25 21:04 WardF

Thanks for the updates! Tests are still missing here so I've started to work on it https://github.com/Unidata/netcdf-c/pull/3118

mannreis avatar Apr 03 '25 12:04 mannreis

Thanks for the updates! Tests are still missing here so I've started to work on it #3118

Sounds good! I've got this pinned for review.

WardF avatar Apr 16 '25 19:04 WardF