netcdf-c icon indicating copy to clipboard operation
netcdf-c copied to clipboard

Convert NCzarr meta-data to use only Zarr attributes

Open DennisHeimbigner opened this issue 1 year ago • 3 comments

As discussed in a netcdf meeting, convert NCZarr V2 to store all netcdf-4 specific info as attributes. This improves interoperability with other Zarr implementations by no longer using non-standard keys. The price to be paid is that lazy attribute reading cannot be supported.

Other Changes

  • Remove support for older NCZarr formats.
  • Update anonymous dimension naming
  • Begin the process of fixing the -Wconversion and -Wsign-compare warnings in libnczarr, nczarr_test, and v3_nczarr_test.
  • Update docs/nczarr.md
  • Rebuild using the .y and .l files

Addendum

As suggested by Ward, I ensured that this PR supports read backward compatibility with old key format. This addition also adds a test case for this.

Misc. Other Changes

  • Remove some unused code
  • Cleanup json error handling
  • Fix some more unsigned/signed conversions warning

DennisHeimbigner avatar Jun 20 '24 00:06 DennisHeimbigner

This looks good, but my main concern is Remove support for older NCZarr formats.. I know they aren't in particularly wide use yet, but is this write support, or read support as well?

WardF avatar Jun 21 '24 22:06 WardF

You are right. I should ensure backward read compatibility. Will take a day or two.

DennisHeimbigner avatar Jun 22 '24 02:06 DennisHeimbigner

This appears to ready to merge.

DennisHeimbigner avatar Jul 03 '24 01:07 DennisHeimbigner