netcdf-c
netcdf-c copied to clipboard
Unidata
CI: Setup a CMake job for MSYS2/MinGW
This keeps dying on me because apparently m4 is not being installed.
Applied 2914 and it still dies because it cannot find m4.
It requires some more changes that i will apply one #2914 got merged.
@DennisHeimbigner I have pushed changes for the build to succeeds, but tests needs more changes to succeed.
You repeatedly change if(MSVC) to if(WIN32). Does that work for cygwin?
You repeatedly change if(MSVC) to if(WIN32). Does that work for cygwin?
No, WIN32 is not defined by CMake on CygWin.
@DennisHeimbigner I'm not seeing an issue on my end from the tests, but I don't have a Cygwin environment to run. It works in MSYS2 with Visual Studio, if you run this manually on your Cygwin environment, does it fail?
DWesl/netcdf-c#2 is a copy of this workflow adapted for Cygwin, which shows a single test failure (a massive improvement over the last time I tried CMake on Cygwin). I don't recognize the reason for the nc_test4_tst_filter failure from the details provided, so I'd have to dig into that locally, but I suspect that failure is unrelated to the changes in this PR.
Can you give a short characterization of the differences between you cygwin .yml and the existing cygwin .yml?
Can you give a short characterization of the differences between your
cygwin.ymland the existingcygwin.yml?
I added a section to build the software and run tests using CMake. This section differs from the Autotools job in the software installed (the CMake job adds gcc-g++, cmake, ninja, and make) and tool used to configure, build, and run the tests.
The CMake section differs from the CMake section here in the action used to install packages (Cygwin instead of MSYS/MinGW) and the build generator used (Unix Makefiles instead of MSYS). I also specified more full paths to utilities. Should I make a PR to add that to this PR or create a new PR?