netcdf-c
netcdf-c copied to clipboard
Fix most warnings in `dumplib.c`
The easy win here was changing the return type of sbuf_len
which is used in a lot of places in this file. Two alternatives that I think would be cleaner but require touching more places:
- Change the
typ_tostring_func
function pointer typedef to returnsize_t
. This is more correct as it matches the current return type ofsbuf_len
, which is returned from the implementations of this prototype. - Change the
typ_tostring_func
return type tovoid
-- as far as I can tell, the return value of these functions isn't used anywhere that they're called, I think it's an entirely internal module. Doing this would also mean that the call tosbuf_len
in these functions could also be removed entirely
This PR fixes about 55 warnings