netcdf-c icon indicating copy to clipboard operation
netcdf-c copied to clipboard

autoreconf warnings

Open edwardhartnett opened this issue 2 years ago • 4 comments

I upgraded to the recently-released ubuntu-22, and now I get these warnings from autoreconf:

configure.ac:1125: warning: The macro `AC_HEADER_STDC' is obsolete.
configure.ac:1125: You should run autoupdate.
./lib/autoconf/headers.m4:704: AC_HEADER_STDC is expanded from...
configure.ac:1125: the top level
configure.ac:1282: warning: The macro `AC_STRUCT_ST_BLKSIZE' is obsolete.
configure.ac:1282: You should run autoupdate.
./lib/autoconf/types.m4:1000: AC_STRUCT_ST_BLKSIZE is expanded from...
configure.ac:1282: the top level
configure.ac:1283: warning: The macro `AC_TRY_RUN' is obsolete.
configure.ac:1283: You should run autoupdate.
./lib/autoconf/general.m4:2997: AC_TRY_RUN is expanded from...
acinclude.m4:9: UD_CHECK_IEEE is expanded from...
configure.ac:1283: the top level

My version:

autoconf --version
autoconf (GNU Autoconf) 2.71

However, these do not prevent the build from working. make check works fine. ;-)

edwardhartnett avatar Jun 01 '22 03:06 edwardhartnett

For more info see: https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Particular-Headers.html

edwardhartnett avatar Jun 01 '22 03:06 edwardhartnett

Removing it as I recall causes other problems with other versions.

DennisHeimbigner avatar Jun 01 '22 04:06 DennisHeimbigner

I am trying to remember what caused the problem. I think it has to do with the autoconf running on ubuntu 18

DennisHeimbigner avatar Jun 01 '22 04:06 DennisHeimbigner

It apparently requires a more recent version of autoconf as well. I notice that autoupdate changed the version of autoconf required at the top of the configure.ac.

Since only developers ever have to run autoreconf, this should be fine. However, as I recommended in the PR, no need to merge this before the 4.9.0 release, so that there's plenty of time to make sure it works everywhere we need it to...

edwardhartnett avatar Jun 01 '22 04:06 edwardhartnett