netcdf-c icon indicating copy to clipboard operation
netcdf-c copied to clipboard

filter tests should not run when HDF5 doesn't support them.

Open WardF opened this issue 6 years ago • 5 comments

Currently, netCDF tries to run the filter tests even if the underlying libhdf5 doesn't support them. This feature should only be available if linking against hdf5 when dynamic filter support is available.

WardF avatar Nov 11 '19 20:11 WardF

This can currently be worked around by passing --disable-filter-testing at configure time or -DENABLE_FILTER_TESTING=OFF when using cmake.

WardF avatar Nov 11 '19 20:11 WardF

When can HDF5 not support filters?

When it's a --disable-shared build, I believe. But under no other circumstances that I am aware of...

edwardhartnett avatar Mar 03 '20 19:03 edwardhartnett

However, even if shared is disabled, it should still be possible to do deflate and szip compression since those would be built into HDF5.

DennisHeimbigner avatar Mar 03 '20 20:03 DennisHeimbigner

@DennisHeimbigner that is correct (also fletcher32 and shuffle filters are also built in).

There does not seem to be any way to turn off filter support in HDF5, except to build static.

edwardhartnett avatar Mar 03 '20 20:03 edwardhartnett

Can this issue be closed? I have not seen any such failures recently...

edwardhartnett avatar May 04 '22 16:05 edwardhartnett