MetPy icon indicating copy to clipboard operation
MetPy copied to clipboard

Consider dropping codecov

Open dopplershift opened this issue 2 years ago • 4 comments

Codecov is occasionally a source of weird CI failures due to dropped reports. We could accomplish the same thing by combining all our testing into a single workflow with a single end job that combines the reports and checks the coverage. (Unsure if/how we could check 100% running tests.) We could also have it upload the HTML report for coverage as an artifact.

Inspired by this blog post and workflow.

dopplershift avatar May 21 '22 23:05 dopplershift

Looks like Ned Batchelder posted about the tests thing: https://nedbatchelder.com/blog/202111/coverage_goals.html

dopplershift avatar May 21 '22 23:05 dopplershift

Also worth noting: https://github.com/nedbat/coveragepy/blob/ad824b4585c88d0a153dd248f4585084dea33189/.github/workflows/coverage.yml#L218-L221

dopplershift avatar May 24 '22 17:05 dopplershift

Regardless of specifically dropping codecov, I do like the idea of moving towards a single testing+coverage report, particularly now with actions summaries. If moving towards that also happens to remove the need for codecov and its occasional hiccups, then I'm on board.

dcamron avatar May 25 '22 16:05 dcamron

Stumbled across this action that might make this easier: https://github.com/py-cov-action/python-coverage-comment-action

dopplershift avatar Apr 10 '24 17:04 dopplershift