MetPy icon indicating copy to clipboard operation
MetPy copied to clipboard

Add mean pressure weighted equation

Open Daviology38 opened this issue 4 years ago • 7 comments

Description Of Changes

This pull request fixes #2094 by adding in the function for pressure-weighted vertical average from Holton 5th Edition 2012 page 86. The reference to Holton 2012 was also added into the references sheet.

Checklist

  • [X] Closes #2094
  • [X] Fully documented

Daviology38 avatar Oct 09 '21 21:10 Daviology38

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 09 '21 21:10 CLAassistant

Actually, I was suggesting using A as a filler variable instead of the (technically incorrect) empty (). Also, I'll note that both MPW and () are listed as variables below the equation.

dopplershift avatar Oct 20 '21 01:10 dopplershift

Actually, I was suggesting using A as a filler variable instead of the (technically incorrect) empty (). Also, I'll note that both MPW and () are listed as variables below the equation.

Daviology38 avatar Oct 20 '21 13:10 Daviology38

Sorry about that, still new to the GitHub workflow when pushing commits, so I accidentally close this one and reopened it.

As for the changes, that makes more sense, I completely glossed over having used '( )' for the variable placeholder. I have made the recommended changes.

Daviology38 avatar Oct 20 '21 13:10 Daviology38

This looks like it's gotten a little messy for some reason and it's a little hard to review. Do you think you could rebase on current the current main branch and do a git push --force? I'm happy to walk you through it if you need help. I'd give you the full instructions right now, but it would depend on what you have called the remote that points to https://github.com/Unidata/MetPy.

dopplershift avatar Nov 02 '21 23:11 dopplershift

I did the rebase and force pushed the branch, hopefully that makes things easier to understand. If not, let me know any other steps I could take, still learning the ins and outs of github, but it's all starting to come together.

Daviology38 avatar Nov 03 '21 16:11 Daviology38

Sorry, I had to do some git rebase surgery to get this back to no extraneous changes. You'll probably want to delete your local branch and re-pull from your fork (I can run down the commands if you need some help.).

dopplershift avatar Nov 11 '21 19:11 dopplershift

Sorry this languished so long! It should be good to go now if all the tests pass.

dopplershift avatar Sep 30 '22 07:09 dopplershift

Congratulations on your first merged PR to MetPy! 🎉 We hope to see you around in the future!

dopplershift avatar Sep 30 '22 17:09 dopplershift