vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Prettier formats lists wrong - Update Prettier dependency

Open stevenzeck opened this issue 7 years ago • 4 comments

From @muuvmuuv on October 24, 2018 7:17

I am using the VS Code extension and every time I format a file it converts the - to * which is wrong regarding this issue https://github.com/prettier/prettier/issues/4251. I don't know why it does this, I thought the beautifiers are using the same version as the CLI does, because when I use the prettier CLI with prettier file.md --write everything is fine.

Prettier: v1.14.3 Unibeautify: v0.6.1 VSCode: 1.28.2

## [1.0.3]

- Updated README
- Moved pre-push to .git

converts to

## [1.0.3]

* Updated README
* Moved pre-push to .git

Config is

{
  "Markdown": {
    "beautifiers": ["Prettier"],
    "wrap_line_length": 80,
    "wrap_prose": "always"
  }
}

Copied from original issue: Unibeautify/beautifier-prettier#127

stevenzeck avatar Oct 26 '18 01:10 stevenzeck

From @muuvmuuv on October 24, 2018 7:19

ah, I forgot to mention that the Unibeautify CI does it the correct way, see: https://github.com/muuvmuuv/vscode-sundial/compare/unibeautify/master/push?expand=1#diff-4ac32a78649ca5bdd8e0ba38b7006a1e

stevenzeck avatar Oct 26 '18 01:10 stevenzeck

Were any changes made by Prettier after 1.12.1? That might be why since VSCode is still on that version.

stevenzeck avatar Oct 26 '18 01:10 stevenzeck

From @muuvmuuv on October 25, 2018 6:42

@stevenzeck yes, see https://prettier.io/blog/2018/05/27/1.13.0.html#change-unordered-list-symbol-to-a-hyphen-4440-by-ikatyang

stevenzeck avatar Oct 26 '18 01:10 stevenzeck

Just need to update prettier for the VSCode extension.

stevenzeck avatar Oct 26 '18 01:10 stevenzeck