vibey icon indicating copy to clipboard operation
vibey copied to clipboard

Event Details Page - A typo was there in the last pr

Open Varghab opened this issue 1 year ago • 11 comments

Related Issue

  • Information about the related issue

Closes: #166

Describe the changes you've made

The changes were not reflected in the main site as there was a small error with the Link component.

Type of change

What sort of change have you made:

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Code style update (formatting, local variables)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update.
  • [ ] This change requires a documentation update

How Has This Been Tested?

Checklist

  • [x] My code follows the guidelines of this project.
  • [x] I have performed a self-review of my own code.
  • [ ] I have commented on my code, particularly wherever it was hard to understand.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no new warnings.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

Varghab avatar Jul 06 '23 08:07 Varghab

@Varghab is attempting to deploy a commit to the unikonf-vibey Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jul 06 '23 08:07 vercel[bot]

@Varghab there was a production error in your last pr. can you please check it out?

Deepu178 avatar Jul 06 '23 09:07 Deepu178

@Deepu178 Would you tell me the exact error? My code has reflected in the main branch but not working properly when clicked on the specific event.

Varghab avatar Jul 06 '23 10:07 Varghab

@Varghab you can run your code in production locally and you will get the error. Build optimization failed: found page without a React Component as default export in pages/events/eventsData

Deepu178 avatar Jul 06 '23 10:07 Deepu178

@Deepu178 My code is working fine locally. I guess the issue is arising from events_data file.

Varghab avatar Jul 06 '23 10:07 Varghab

did you try running @Varghab pnpm run build and if yes is it working fine?

Deepu178 avatar Jul 06 '23 10:07 Deepu178

@Deepu178 I guess I figured out the issue, this is probably happening because I have used eventsData.tsx instead of _eventsData.tsx

Varghab avatar Jul 06 '23 10:07 Varghab

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vibey ❌ Failed (Inspect) Jul 6, 2023 10:37am

vercel[bot] avatar Jul 06 '23 10:07 vercel[bot]

@Deepu178 I have fixed the issue, merging this PR should work.

Varghab avatar Jul 06 '23 10:07 Varghab

No, it will not fix the error @Varghab like if you want I can fix the issue

Deepu178 avatar Jul 06 '23 11:07 Deepu178

@Deepu178 Do you know why is that happening?

Varghab avatar Jul 06 '23 11:07 Varghab