UndertaleModTool icon indicating copy to clipboard operation
UndertaleModTool copied to clipboard

Flags appear to have changed, or can't be read properly for some reason. (Handle unidentified flags)

Open ToughSun14 opened this issue 3 years ago • 5 comments

While I was examining the data package for some test compiles on my project, I noticed that the flags line had changed from text to a string of numbers. Either something changed in the data package, or UMT now can't read them for some reason. Either way, I suggest this be looked into. 2022-03-20-edited Here's the data package in question: https://mega.nz/file/PrQDxahZ#bWQa26VMFI72wUoX7IegzhJUqAmY18eXWixNLH7LM70

ToughSun14 avatar Mar 21 '22 01:03 ToughSun14

How flags work is that they're actually a number, it's parsed in a certain way to look like actual flags. The different values added together represent different flags. These are bit flags. So the reason that it's showing up like that is because there is probably an unknown flag that's messing everything up.

Therefore, these new flag(s) need to be identified, added, and also add some sort of error handling to handle future unknown flags.

Grossley avatar Apr 13 '22 00:04 Grossley

Flags in this data file now show correctly (SyncVertex1, Scale, ShowCursor), but I'm unsure if error handling has been added.

Jacky720 avatar Feb 19 '24 23:02 Jacky720

Not as far as i'm aware. Should be relatively simple to just add a read.submitWarning or whatever that function is called during tag reading

Miepee avatar Feb 19 '24 23:02 Miepee

Flags in this data file now show correctly (SyncVertex1, Scale, ShowCursor), but I'm unsure if error handling has been added.

Well, it seems to have done something, but it's not exactly what I was looking for when I said flags. I was more talking about the "flags" bar in the "options" section of the general data. That's what doesn't show up properly. (example: in the deltarune demo, the flags section reads "UseNewAudio, ScreenKey, VariableErrors, FastCollisionCompatibility", but in my test compiles it reads a random number string as seen by the image in this thread. Sorry about the confusion, I didn't show that in the old image. Here's a new one that properly shows it) image_2024-02-19_192756706

ToughSun14 avatar Feb 20 '24 00:02 ToughSun14

Oh, I was looking at the regular Flags. Although Deltarune v1.15 also shows numbers in those fields.

Jacky720 avatar Feb 20 '24 00:02 Jacky720