UndertaleModTool icon indicating copy to clipboard operation
UndertaleModTool copied to clipboard

Second-pass asset resolution

Open Jacky720 opened this issue 1 year ago • 1 comments

Description

This PR adds a second pass to asset resolution following high-level decompilation, which can identify and resolve switch cases past the first. Closes #1374.

Caveats

Limited testing has been performed. Improves asset resolution on 22 code entries of Undertale v1.08, but has slight errors on 2 others: incorrectly resolving obj_woshua.mycommand as a boolean due to a strange if mycommand check, and removing the accurate boolean resolution from selected2 in scr_namingscreen because the correct resolution was a happy accident of the way resolution was implemented. Speed has also not been tested.

Notes

N/A

Jacky720 avatar Feb 22 '24 20:02 Jacky720

Closing now as it will be fixed by new decompiler and will thus not get merged

Miepee avatar Jul 11 '24 05:07 Miepee