UndertaleModTool Calculate length of texture data during serialization instead of writing a set value & Update ImportGMS2FontData

Calculate length of texture data during serialization instead of writing a set value & Update ImportGMS2FontData

Open Dobby233Liu opened this issue 2 years ago • 5 comments

Fixes #1042

This is a quite weird implementation, and I have no idea if it is correct or clean enough. Would like some feedback.

Should _TextureBlockSize be removed altogether?

~~NTS: actually test~~ ImportGMS2FontData and NewTextureRepacker works correctly

Jul 13 '22 03:07 Dobby233Liu

I should also check if the value is written for games that use PNG

Jul 13 '22 03:07 Dobby233Liu

Download the artifacts for this pull request here:

GUI:

CLI:

Jul 13 '22 03:07 github-actions[bot]

Uh, won't this not work on pre-2022.3 games?

Aug 31 '22 01:08 Jacky720

Hmm, I haven't checked

Aug 31 '22 02:08 Dobby233Liu

Added 2022.3 checks, should be correct now

I should also check if the value is written for games that use PNG

Also we still need to check this

Aug 31 '22 02:08 Dobby233Liu

What is the status of this pull request?

Nov 11 '22 15:11 Grossley